Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Search): restore default component size #8912

Merged
merged 3 commits into from
Jun 15, 2021
Merged

fix(Search): restore default component size #8912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6799f1
fix(Search): restore default component size
emyarod Jun 15, 2021
b0bbe91
chore: update snapshots
emyarod Jun 15, 2021
ebc22ea
Merge branch 'main' into 8900-search-component-default-sizing
kodiakhq[bot] Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2335,7 +2335,7 @@ exports[`DataTable should render 1`] = `
>
<div
aria-labelledby="custom-id-search"
className="bx--search bx--toolbar-search-container-persistent"
className="bx--search bx--search--xl bx--toolbar-search-container-persistent"
role="search"
>
<div
Expand Down Expand Up @@ -3396,7 +3396,7 @@ exports[`DataTable sticky header should render 1`] = `
>
<div
aria-labelledby="custom-id-search"
className="bx--search bx--toolbar-search-container-persistent"
className="bx--search bx--search--xl bx--toolbar-search-container-persistent"
role="search"
>
<div
Expand Down
2 changes: 1 addition & 1 deletion ...es/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarSearch-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ exports[`DataTable.TableToolbarSearch should render 1`] = `
>
<div
aria-labelledby="custom-id-search"
className="bx--search custom-class bx--toolbar-search-container-expandable"
className="bx--search bx--search--xl custom-class bx--toolbar-search-container-expandable"
role="search"
>
<div
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/Search/Search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export default class Search extends Component {
labelText,
closeButtonLabelText,
small,
size = !small ? '' : 'sm',
size = !small ? 'xl' : 'sm',
light,
disabled,
onChange,
Expand Down