Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(colors): update classic sass file variable initialization #8670

Merged

Conversation

joshblack
Copy link
Contributor

Closes #8565

This updates our color build step to emit all variables before the mixins in the file.

Changelog

New

Changed

  • Update the colors build step to emit all variables before the mixins in the file

Removed

Testing / Reviewing

  • Pull down the PR and run yarn build in packages/colors
  • Inspect scss/_mixins.scss
  • Verify that all color variables are declared at the start of the file that are included in the ibm--colors and carbon--colors mixins
  • Verify that all variables defined in the mixins use the !global flag

@joshblack joshblack requested a review from a team as a code owner May 12, 2021 17:33
@netlify
Copy link

netlify bot commented May 12, 2021

Deploy preview for carbon-elements ready!

Built with commit f48100c

https://deploy-preview-8670--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented May 12, 2021

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything building as expected 👍🏻 ✅

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also built as expected!

@kodiakhq kodiakhq bot merged commit fa7f540 into carbon-design-system:main May 13, 2021
@tw15egan tw15egan mentioned this pull request May 13, 2021
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update colors build task to emit all variables
4 participants