fix(TooltipDefinition): sync hidden state with other tooltip components #8655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit f4507da |
|
Deploy preview for carbon-components-react failed. Built without sensitive environment variables with commit f4507da https://app.netlify.com/sites/carbon-components-react/deploys/609d5437d8cd7f000732f1a3 |
emyarod
reviewed
May 12, 2021
b85e333 to
7b9fe4b
Compare
joshblack
approved these changes
May 12, 2021
emyarod
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8654
Adds in similar logic to
TooltipDefinitionthat is used in icon only buttons and tooltip iconsChangelog
Changed
focusandblurhandlers now function similarly toTooltipIconhasIconOnlyvariant of buttonTesting / Reviewing
Added a test story under
TooltipDefinition. Ensure focusing on both elements will not prevent the tooltip from appearing.