fix(BreadcrumbItem): do not overwrite child className #8578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO Assistant Lite bot All contributors have signed the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
|
Deploy preview for carbon-elements ready! Built with commit 65e7d92 |
tay1orjones
previously requested changes
May 4, 2021
|
Deploy preview for carbon-components-react ready! Built with commit 65e7d92 https://deploy-preview-8578--carbon-components-react.netlify.app |
joshblack
suggested changes
May 4, 2021
…ild classname check
joshblack
approved these changes
May 7, 2021
Comments were addressed, I believe!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BreadcrumbItemcurrent overwrites the className of itschildren, which should not occur. CodesandboxChangelog
Changed
classNametochildrenforBreadcrumbItemsTesting / Reviewing
Ensure that
BreadcrumbItemchildren maintain the classname they are given.