Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): update component tokens to not include reset #8538

Merged

Conversation

joshblack
Copy link
Contributor

Closes #8500

Update our component tokens to import from theme-tokens instead of theme. This allows them to import tokens without including a CSS reset.

Changelog

New

Changed

  • Update component tokens to import from theme-tokens instead of theme

Removed

@joshblack joshblack requested a review from a team as a code owner April 29, 2021 17:09
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@netlify
Copy link

netlify bot commented Apr 29, 2021

Deploy preview for carbon-elements ready!

Built with commit f610274

https://deploy-preview-8538--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Apr 29, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit f610274

https://deploy-preview-8538--carbon-components-react.netlify.app

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kodiakhq kodiakhq bot merged commit a297449 into carbon-design-system:main May 4, 2021
@tw15egan tw15egan mentioned this pull request May 10, 2021
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[carbon-components]: component tokens.scss files import CSS reset and base styles
3 participants