fix(button): set aria-pressed to props.isSelected for icon-only ghost #7900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 89a00e9 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 89a00e9 https://deploy-preview-7900--carbon-components-react.netlify.app |
joshblack
approved these changes
Feb 25, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #7757, #7784
Following the WAI-ARIA Authoring Practices for toggle buttons, this PR sets the button's
aria-pressedattribute according toprops.isSelected(if it is icon-only and ghost).Changelog
New
aria-pressedattribute to button icon-only ghost buttons to reflectprops.isSelectedChanged
Testing / Reviewing
props.isSelectedis not passed, the button should not have thearia-pressedattribute.props.isSelected = falseis passed, the button should havearia-pressed="false"props.isSelected = trueis passed, the button should havearia-pressed="true"props.isSelected = trueis passed but the button is not icon-only and ghost, the butto should not have thearia-pressedattribute