fix(elements): use explicit exports from motion to prevent duplicates #7840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 88be1b7 |
|
Deploy preview for carbon-components-react ready! Built with commit 88be1b7 https://deploy-preview-7840--carbon-components-react.netlify.app |
|
@tw15egan @andreancardona just a heads up, going to force merge this for release this afternoon. Let me know if this is a problem, happy to revert if something comes up 👀 |
This was referenced Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up during our 10.29 release. The motion package and type package both share
unstable_tokensexports. Re-exporting all members from themotionpackage caused duplicates to appear in the ESM build. This PR addresses that by using explicit exports from the motion packageChangelog
New
Changed
Removed