Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ProgressIndicator): add description title to warning icon #7794

Conversation

briangleeson
Copy link
Contributor

Closes #7793

Add hover text for warning icon on steps in ProgressIndicator

Changelog

Changed

  • <title>{description}</title> added to the warning icon in ProgressIndicator component

Testing / Reviewing

  • Hover the mouse on the warning icon on a progress step of a progress indicator, the description value should display on hover

@briangleeson briangleeson requested a review from a team as a code owner February 12, 2021 14:19
@netlify
Copy link

netlify bot commented Feb 12, 2021

Deploy preview for carbon-elements ready!

Built with commit 1892763

https://deploy-preview-7794--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 12, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 1892763

https://deploy-preview-7794--carbon-components-react.netlify.app

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 82abdc6 into carbon-design-system:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProgressIndicator invalid icon hover text
3 participants