feat(ui-shell): add side-nav-divider component #7756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit c4a389d |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit c4a389d https://deploy-preview-7756--carbon-components-react.netlify.app |
emyarod
approved these changes
Feb 8, 2021
aagonzales
requested changes
Feb 8, 2021
joshblack
reviewed
Feb 9, 2021
joshblack
approved these changes
Feb 9, 2021
joshblack
approved these changes
Feb 10, 2021
This was referenced Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new component for the SideNav:
<SideNavDivider />.It renders a diving line with the styling used on carbondesignsystem.com
Changelog
New
SideNavDividercomponentChanged
Testing / Reviewing
Additional information
I opted for an
<li>with the roleseparatorinstead of an<hr>element since according to the HTML spec, children of a<ul>must be<li>elements (https://html.spec.whatwg.org/multipage/grouping-content.html#the-hr-element) and the<hr>element has the implicit roleseparator(https://w3c.github.io/html-aam/#el-hr).