[WIP] feat(globals): update colors and added new inputs #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(text-input): started working on new styles * feat(text-inputs): added new variations of text inputs * feat(text-inputs): added new styles to text area * feat(text-inputs): added new styles to date picker * feat(inputs): finished up first iteration of inptus
* feat(color): start updating colors * feat(color): update more colors * feat(color): update hover colors * feat(color): tweak some more colors * feat(color): update date-picker colors * feat(color): update table colors
* feat(text-input): started working on new styles * feat(text-inputs): added new variations of text inputs * feat(text-inputs): added new styles to text area * feat(text-inputs): added new styles to date picker * feat(inputs): finished up first iteration of inptus
* feat(color): start updating colors * feat(color): update more colors * feat(color): update hover colors * feat(color): tweak some more colors * feat(color): update date-picker colors * feat(color): update table colors
|
The placeholder text shifts 1px over on the active state because of the border. Is this intended behavior? Fix could be to add 1px transparent border to the input. We can't use outline because of the IE/modal issue right? Oh wait, is the border even supposed to be there? |
|
closing this as I messed up the other one.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ref https://github.ibm.com/carbon/issues/issues/613
Ref https://github.ibm.com/carbon/issues/issues/446
Ref https://github.ibm.com/carbon/issues/issues/545
Resolves #690
This PR is a combination of #711 and #710.
Added
$field-02and$inverse-02Changed
Dropdownhover colors$ui-05to$ui-04$ui-04to$ui-03$ui-03to$ui-02$field-01to$field-02$text-03to$text-02