Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dataTable): search accessibility issue #7359

Merged
merged 5 commits into from
Dec 7, 2020
Merged

fix(dataTable): search accessibility issue #7359

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cdba001
fix(dataTable): search accessibility issue
Nov 30, 2020
3f446e7
Removed Aria-hidden.
CassidyJensen Dec 1, 2020
69c0d46
chore: update snapshots
emyarod Dec 1, 2020
6b9d293
Merge branch 'master' into table-toolbar-search-accessibility
tw15egan Dec 1, 2020
bcbc6f8
Merge branch 'master' into table-toolbar-search-accessibility
kodiakhq[bot] Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/react/src/components/DataTable/TableToolbarSearch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ const TableToolbarSearch = ({
className={className}
value={value}
id={typeof id !== 'undefined' ? id : uniqueId.toString()}
aria-hidden={!searchExpanded}
labelText={labelText || t('carbon.table.toolbar.search.label')}
placeHolderText={
placeHolderText || t('carbon.table.toolbar.search.placeholder')
Expand Down
4 changes: 0 additions & 4 deletions packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2295,7 +2295,6 @@ exports[`DataTable should render 1`] = `
tabIndex="-1"
>
<Search
aria-hidden={false}
closeButtonLabelText="Clear search input"
id="custom-id"
labelText="Filter table"
Expand Down Expand Up @@ -2348,7 +2347,6 @@ exports[`DataTable should render 1`] = `
Filter table
</label>
<input
aria-hidden={false}
autoComplete="off"
className="bx--search-input"
id="custom-id"
Expand Down Expand Up @@ -3303,7 +3301,6 @@ exports[`DataTable sticky header should render 1`] = `
tabIndex="-1"
>
<Search
aria-hidden={false}
closeButtonLabelText="Clear search input"
id="custom-id"
labelText="Filter table"
Expand Down Expand Up @@ -3356,7 +3353,6 @@ exports[`DataTable sticky header should render 1`] = `
Filter table
</label>
<input
aria-hidden={false}
autoComplete="off"
className="bx--search-input"
id="custom-id"
Expand Down
2 changes: 0 additions & 2 deletions ...es/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarSearch-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ exports[`DataTable.TableToolbarSearch should render 1`] = `
tabIndex="0"
>
<Search
aria-hidden={true}
className="custom-class"
closeButtonLabelText="Clear search input"
id="custom-id"
Expand Down Expand Up @@ -72,7 +71,6 @@ exports[`DataTable.TableToolbarSearch should render 1`] = `
Filter table
</label>
<input
aria-hidden={true}
autoComplete="off"
className="bx--search-input"
id="custom-id"
Expand Down