fix(pagination): fix the select input to support multi-digits numbers #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carbon-design-system/ui Would you agree with the style change...? Thanks! |
|
Noticed some style discrepancies when checking out the PR:
Any chance we can get those fixed? |
|
Encountering this issue outside of this PR: #691 |
|
Still seeing some style issues with this PR: |
…nents into pagination
|
Seeing an issue that when there is a large option (I put in a value of 500 in the
Seems like adding
|
|
Yes it's possible |
marijohannessen
approved these changes
Apr 17, 2018
tw15egan
approved these changes
Apr 17, 2018
|
@tw15egan just a heads up that |
|
@mven of course 🙄 . If we get any complaints about misalignment in Safari we can reopen this and try and find a more elegant solution. |
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves
#607
and this issue :
https://github.com/carbon-design-system/carbon-components-react/issues/732
in carbon-components-react
applying width:auto to the select-input and select--inline to support multi-digits numbers and render them without any overflow
Added
Removed
Changed
Testing / Reviewing