test(Slider): fix flaky test #5594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a flaky test in one for React `<Slider>`, which was caused by an assumption that a timer fires in a certain timing. Fixed by not running timer in test.
|
Deploy preview for carbon-components-react ready! Built with commit 262c712 https://deploy-preview-5594--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 262c712 |
joshblack
approved these changes
Mar 11, 2020
abbeyhrt
approved these changes
Mar 11, 2020
tw15egan
approved these changes
Mar 11, 2020
aledavila
pushed a commit
that referenced
this pull request
Mar 18, 2020
This change fixes a flaky test in one for React `<Slider>`, which was caused by an assumption that a timer fires in a certain timing. Fixed by not running timer in test.
This was referenced Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a flaky test in one for React
<Slider>, which was caused by an assumption that a timer fires in a certain timing. Fixed by not running timer in test.Changelog
Changed
<Slider>test to mocklodash.throttle