Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tile): add non link styling to clickable tile #5591

Merged
merged 4 commits into from
Mar 11, 2020
Merged

fix(tile): add non link styling to clickable tile #5591

merged 4 commits into from
Mar 11, 2020

Conversation

aledavila
Copy link
Contributor

Closes #4850

Follows similar pattern to clickable tile on website. Adds styles to make the content inside the tile to not look like links.

Changelog

New

  • adds non link styles in clickable tile

Removed

  • removed --tile class from clickable tile

@aledavila aledavila requested a review from a team as a code owner March 10, 2020 21:30
@ghost ghost requested review from abbeyhrt and tw15egan March 10, 2020 21:30
@netlify
Copy link

netlify bot commented Mar 10, 2020

Deploy preview for carbon-components-react ready!

Built with commit e47f6cb

https://deploy-preview-5591--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Mar 10, 2020

Deploy preview for carbon-elements ready!

Built with commit e47f6cb

https://deploy-preview-5591--carbon-elements.netlify.com

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉

@abbeyhrt abbeyhrt requested review from a team and designertyler and removed request for a team March 10, 2020 21:52
@netlify
Copy link

netlify bot commented Mar 10, 2020

Deploy preview for carbon-components-react ready!

Built with commit 83f7808

https://deploy-preview-5591--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Mar 10, 2020

Deploy preview for carbon-elements ready!

Built with commit 83f7808

https://deploy-preview-5591--carbon-elements.netlify.com

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 ✅

@aledavila aledavila requested review from tw15egan and laurenmrice and removed request for designertyler March 11, 2020 14:22
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 🙌🏻

@aledavila aledavila merged commit c5658ce into carbon-design-system:master Mar 11, 2020
aledavila pushed a commit that referenced this pull request Mar 18, 2020
Co-authored-by: TJ Egan <tw15egan@gmail.com>
Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
This was referenced Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(tile) clickable tile should not have blue text
5 participants