-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(icon): Remove redundant 16px variants #5563
Merged
tw15egan
merged 9 commits into
carbon-design-system:master
from
chrisconnors-ibm:remove-redundant-16s
Mar 10, 2020
Merged
fix(icon): Remove redundant 16px variants #5563
tw15egan
merged 9 commits into
carbon-design-system:master
from
chrisconnors-ibm:remove-redundant-16s
Mar 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed redundant 16s, edited icons.yml
… into remove-redundant-16s
… into remove-redundant-16s
joshblack
approved these changes
Mar 6, 2020
Deploy preview for carbon-components-react ready! Built with commit 4aa03e5 https://deploy-preview-5563--carbon-components-react.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 4aa03e5 |
The |
the master Ai file and my personal library use |
laurenmrice
approved these changes
Mar 9, 2020
conradennis
approved these changes
Mar 9, 2020
… into remove-redundant-16s
updates deprecated.yml to reflect deprecation of delete.svg
tw15egan
approved these changes
Mar 9, 2020
emyarod
approved these changes
Mar 10, 2020
chrisconnors-ibm
changed the title
Remove redundant 16px variants
fix(icon): Remove redundant 16px variants
Mar 10, 2020
aledavila
pushed a commit
that referenced
this pull request
Mar 18, 2020
* remove redundant 16s removed redundant 16s, edited icons.yml * remove redundant 16s * Update deprecated.yml updates deprecated.yml to reflect deprecation of delete.svg Co-authored-by: TJ Egan <tw15egan@gmail.com>
This was referenced Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR removes redundant 16px variants that were just scaled from the 32. updates
packages/icons/icons.yml
to reflect the changes.Changelog
Changed
packages/icons/icons.yml
to remove references to removed 16px variantspackages/icons/deprecated.yml
to adddelete.svg
to deprecated listRemoved
16/code.svg
16/delete.svg
16/edit--off.svg
16/email.svg
16/favorite--filled.svg
16/favorite.svg
16/grid.svg
16/locked.svg
16/trash-can.svg
Testing / Reviewing
Review all sizes on @1x and @2x displays
code.svg
delete.svg
edit--off.svg
email.svg
favorite--filled.svg
favorite.svg
grid.svg
locked.svg
trash-can.svg