Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): Remove redundant 16px variants #5563

Merged

Conversation

chrisconnors-ibm
Copy link
Contributor

@chrisconnors-ibm chrisconnors-ibm commented Mar 6, 2020

PR removes redundant 16px variants that were just scaled from the 32. updates packages/icons/icons.yml to reflect the changes.

Changelog

Changed

  • updates packages/icons/icons.yml to remove references to removed 16px variants
  • updates packages/icons/deprecated.yml to add delete.svg to deprecated list

Removed

  • 16/code.svg
    16/delete.svg
    16/edit--off.svg
    16/email.svg
    16/favorite--filled.svg
    16/favorite.svg
    16/grid.svg
    16/locked.svg
    16/trash-can.svg

Testing / Reviewing

Review all sizes on @1x and @2x displays
code.svg
delete.svg
edit--off.svg
email.svg
favorite--filled.svg
favorite.svg
grid.svg
locked.svg
trash-can.svg

@chrisconnors-ibm chrisconnors-ibm requested review from laurenmrice and a team as code owners March 6, 2020 21:57
@ghost ghost requested review from asudoh and emyarod March 6, 2020 21:58
@netlify
Copy link

netlify bot commented Mar 6, 2020

Deploy preview for carbon-components-react ready!

Built with commit 4aa03e5

https://deploy-preview-5563--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Mar 6, 2020

Deploy preview for carbon-elements ready!

Built with commit 4aa03e5

https://deploy-preview-5563--carbon-elements.netlify.com

@laurenmrice
Copy link
Member

The trash-can and delete icon are the same. Do we know which one we want to eventually deprecate?

@conradennis
Copy link
Contributor

the master Ai file and my personal library use trash-can

@chrisconnors-ibm chrisconnors-ibm changed the title Remove redundant 16px variants fix(icon): Remove redundant 16px variants Mar 10, 2020
@tw15egan tw15egan merged commit b8187fa into carbon-design-system:master Mar 10, 2020
@chrisconnors-ibm chrisconnors-ibm deleted the remove-redundant-16s branch March 10, 2020 21:02
aledavila pushed a commit that referenced this pull request Mar 18, 2020
* remove redundant 16s

removed redundant 16s, edited icons.yml

* remove redundant 16s

* Update deprecated.yml

updates deprecated.yml to reflect deprecation of delete.svg

Co-authored-by: TJ Egan <tw15egan@gmail.com>
This was referenced Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants