chore(components): change visibility style #5552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses a common known problem of `visibility:visible` style; If an element with `visibility:hidden` has a child element with `visibility:visible`, the child element will be visible even though in most cases it's expected that the entire content (including the child element) is hidden. Refs carbon-design-system#5545.
|
Deploy preview for carbon-components-react ready! Built with commit 547596b https://deploy-preview-5552--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 547596b |
tw15egan
approved these changes
Mar 6, 2020
jeanservaas
approved these changes
Mar 10, 2020
aledavila
pushed a commit
that referenced
this pull request
Mar 18, 2020
This change addresses a common known problem of `visibility:visible` style; If an element with `visibility:hidden` has a child element with `visibility:visible`, the child element will be visible even though in most cases it's expected that the entire content (including the child element) is hidden. Refs #5545.
This was referenced Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses a common known problem of
visibility:visiblestyle; If an element withvisibility:hiddenhas a child element withvisibility:visible, the child element will be visible even though in most cases it's expected that the entire content (including the child element) is hidden: https://jakearchibald.com/2014/visible-undoes-hidden/Refs #5545.
Changelog
Changed
visibility:visiblestyle withvisibility:inheritTesting / Reviewing
Testing should make sure the following are not broken: