Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(file-uploader): show legacy file uploader in vanilla docs #5265

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Feb 4, 2020

Closes #5247

This PR adds the legacy file uploader back into the vanilla docs

Testing / Reviewing

Ensure the file uploader functions as expected

@netlify
Copy link

netlify bot commented Feb 4, 2020

Deploy preview for carbon-components-react failed.

Built with commit 5ef7b94

https://app.netlify.com/sites/carbon-components-react/deploys/5e3c93bf754787000863b5ca

@netlify
Copy link

netlify bot commented Feb 4, 2020

Deploy preview for carbon-elements ready!

Built with commit 5ef7b94

https://deploy-preview-5265--carbon-elements.netlify.com

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding that in 👍 ✅

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@asudoh
Copy link
Contributor

asudoh commented Feb 6, 2020

Got green light from @emyarod to move this to "ready to merge" state.

@asudoh asudoh merged commit 1ac4f59 into carbon-design-system:master Feb 6, 2020
@emyarod emyarod deleted the 5247-add-legacy-vanilla-file-uploader branch February 10, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[file uploader] Add default file uploader to vanilla
6 participants