Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(project): update dependencies january 2020 #5183

Merged
merged 4 commits into from
Jan 27, 2020
Merged

chore(project): update dependencies january 2020 #5183

merged 4 commits into from
Jan 27, 2020

Conversation

joshblack
Copy link
Contributor

Runs yarn upgrade on the project to upgrade remaining dependencies. Helps to get rid of the caniuse-lite warnings that have been showing up for a bit 😅

Tried to test this as much as I could, running yarn build and yarn ci-check and so far everything is checking out. Let me know if you run into anything breaking!

Changelog

New

Changed

  • Offline mirror and yarn.lock

Removed

@joshblack joshblack requested a review from a team as a code owner January 26, 2020 00:35
@ghost ghost requested review from aledavila and dakahn January 26, 2020 00:35
@netlify
Copy link

netlify bot commented Jan 26, 2020 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit ac6f07b

https://deploy-preview-5183--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 26, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit ac6f07b

https://deploy-preview-5183--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 26, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit ac6f07b

https://deploy-preview-5183--carbon-components-react.netlify.com

@joshblack joshblack mentioned this pull request Jan 26, 2020
Merged
emyarod
emyarod reviewed Jan 27, 2020
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built and tested locally in advance of looking at #5184, there seems to be a prettier formatting error when running ci-check

@joshblack
Copy link
Contributor Author

@emyarod CI should be green now!

tw15egan
tw15egan approved these changes Jan 27, 2020
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran yarn build and yarn ci-check and getting all green 👍 ✅

@joshblack joshblack merged commit 4f1a4aa into carbon-design-system:master Jan 27, 2020
@joshblack joshblack deleted the chore/update-dependencies-jan-2020 branch January 27, 2020 20:44
@joshblack joshblack mentioned this pull request Jan 31, 2020
Closed
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod left review comments

@dakahn dakahn dakahn approved these changes

@tw15egan tw15egan tw15egan approved these changes

@aledavila aledavila Awaiting requested review from aledavila

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshblack @emyarod @tw15egan @dakahn