Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(multi-select): fix DAP violations #4991

Merged
merged 6 commits into from
Jan 10, 2020
Merged

fix(multi-select): fix DAP violations #4991

merged 6 commits into from
Jan 10, 2020

Conversation

aledavila
Copy link
Contributor

Closes #4007

worked with @joshblack during mob programming.
DAP violations for proper labeling have been cleared.

Add

  • added aria-labelledby to Multiselect.menu to be labeled by main label

Removed

  • removed role='listbox' from ListBox component. We concluded it's not needed on the outside container. The Listbox menu already has a role='listbox'

  • removed unnecessary aria from outer multiselect container.

@dakahn was wondering if you can take a look at the issue and thoughts on the DAP violations for the checkbox group (doesn't have proper grouping).

@aledavila aledavila requested a review from a team as a code owner January 9, 2020 17:36
@aledavila aledavila requested review from asudoh and joshblack January 9, 2020 17:36
@netlify
Copy link

netlify bot commented Jan 9, 2020

Deploy preview for the-carbon-components ready!

Built with commit 194f9fa

https://deploy-preview-4991--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 9, 2020

Deploy preview for carbon-components-react ready!

Built with commit 194f9fa

https://deploy-preview-4991--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jan 9, 2020

Deploy preview for carbon-elements ready!

Built with commit 194f9fa

https://deploy-preview-4991--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 9, 2020 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit dc7c9a5

https://deploy-preview-4991--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 9, 2020 •
edited
Loading

Deploy preview for carbon-elements failed.

Built with commit dc7c9a5

https://app.netlify.com/sites/carbon-elements/deploys/5e18ab92c7b810000899b790

@netlify
Copy link

netlify bot commented Jan 9, 2020 •
edited
Loading

Deploy preview for carbon-components-react failed.

Built with commit dc7c9a5

https://app.netlify.com/sites/carbon-components-react/deploys/5e18ab9216008d000891265c

asudoh
asudoh approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Could you update the snapshot? Thanks @aledavila!

tw15egan
tw15egan approved these changes Jan 9, 2020
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, confirmed the DAP violations are no longer appearing 👍

emyarod
emyarod approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just need to update snapshots to pass CI

@aledavila aledavila merged commit 8a20d0e into carbon-design-system:master Jan 10, 2020
@aledavila aledavila deleted the multiselect-4007 branch January 10, 2020 17:08
joshblack pushed a commit to joshblack/carbon that referenced this pull request Jan 13, 2020
@tw15egan @joshblack
fix(multi-select): fix DAP violations (carbon-design-system#4991)
be3a798 
* fix(multi-select): add arialabeledby to menu

* fix(list-box): remove role from listbox

* chore: remove console log

* chore: update snapshots

Co-authored-by: TJ Egan <tw15egan@gmail.com>
@joshblack joshblack mentioned this pull request Jan 13, 2020
Closed
joshblack added a commit to joshblack/carbon that referenced this pull request Jan 13, 2020
@joshblack
Revert "fix(multi-select): fix DAP violations (carbon-design-system#4991
99606a8 
)"

This reverts commit 8a20d0e.
@joshblack joshblack mentioned this pull request Jan 31, 2020
Closed
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
@joshblack joshblack mentioned this pull request Mar 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@emyarod emyarod emyarod approved these changes

@asudoh asudoh asudoh approved these changes

@joshblack joshblack Awaiting requested review from joshblack

Assignees
No one assigned
Labels
status: failing CI 🙅‍♂️ status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AVT 1 - React MultiSelect w/initial selected item has DAP violations
4 participants
@aledavila @asudoh @emyarod @tw15egan