Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update package.json engines field #448

Merged
merged 4 commits into from
Nov 30, 2017
Merged

Conversation

joshblack
Copy link
Contributor

Replaces engines field with the devEngines field. Should help with consumers not having a valid node or yarn range, while still allowing the development team to specify specific versions for development-related purposes.

@joshblack
Copy link
Contributor Author

cc @carbon-design-system/ui

Not sure if yarn actually looks into devEngines or not, just saw in a React PR that they use it for node. Testing locally it doesn't seem like Yarn supports it which is kind of a bummer 😞 any thoughts on how to enforce yarn range? Can do it in the engines field but not sure if that's a proper requirement on consumers.

@marijohannessen
Copy link
Contributor

Scratch my last comment. I think putting it in engines is fine, I was overthinking it :-)

@marijohannessen marijohannessen merged commit 546a7e4 into master Nov 30, 2017
@joshblack joshblack deleted the add-dev-engine branch November 30, 2017 20:43
joshblack pushed a commit to joshblack/carbon that referenced this pull request May 2, 2019
…n Carbon Design System (carbon-design-system#448)

The ILN can now collapse. Only one list will be open at a time, the others will close if they are
open. removed the header. updated storybook and unit tests.

fixes carbon-design-system#439.
joshblack added a commit to joshblack/carbon that referenced this pull request May 8, 2019
* fix(themes): update to include all tokens

* chore(icons-angular): remove devDependency

* fix(themes): update scss output with new tokens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants