Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(number-input): add number input disabled styles back in #447

Merged

Conversation

tw15egan
Copy link
Collaborator

Number input was missing the disabled styles. This adds them back in. May also affect carbon-design-system/carbon-components-react#360

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍 ✅

@tw15egan
Copy link
Collaborator Author

This also now adds in invalid number styles. Goes with carbon-design-system/carbon-components-react#376

@marijohannessen marijohannessen merged commit 8ca3986 into carbon-design-system:master Nov 30, 2017
joshblack pushed a commit to joshblack/carbon that referenced this pull request May 2, 2019
…arbon-design-system#447)

* fix(interior-left-nav): refactored so it accepts react router links

* fix(interior-left-nav): started adding in active check

* fix(interior-left-nav): added active href check

* fix(interior-left-nav): fixed tests

* fix(interior-left-nav): removed react router
designertyler pushed a commit to designertyler/carbon that referenced this pull request Oct 14, 2019
@tw15egan tw15egan deleted the number-input-fix branch April 28, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants