fix(notification): use correct closing element #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
* feat: add children-specific prop-type validators * feat: add generic ListBox for dropdown-based components * chore: update tests to use valid children nodes
designertyler
pushed a commit
to designertyler/carbon
that referenced
this pull request
Oct 14, 2019
…on-design-system#377) * feat: add layout code page content * feat: add first grid demo * fix: row width * chore: formatting * fix: 16 col grid * chore: add missing margin * feat: add code snippet * feat: add more grid examples * chore: remove extra div * feat: update grid examples * feat: add aspect ratio code snippets * feat: update theme version, add getting started content * feat: add shell examples * chore: * test * feat: add images * feat: add images and video to layout code page * chore: add row * chore: add missing code snippet * chore: remove accidental images * chore: fix broken build * fix: update grid padding and video * feat: add demo classes * layout code tab stuff * text updates * Apply suggestions from code review Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com> * image updates * image updates * Layout code (carbon-design-system#423) * test * layout code tab stuff * text updates * Apply suggestions from code review Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com> * image updates * image updates * update code for side nav example * Update code.mdx * feat: add bleed demo * feat: update responsive options demo * feat: update offset examples * fix: update code samples * fix: shell demo * fix: code snippet length * fix: update condensed example * fix: spacing grid modes images * content and image updates * image update * img update * img update * text update * Update _grid-demo.scss * Update code.mdx * chore: delete file * nav update * Layout code (carbon-design-system#432) * test * layout code tab stuff * text updates * Apply suggestions from code review Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com> * image updates * image updates * Update code.mdx * content and image updates * image update * img update * img update * text update * nav update * fix: hide cozy code and fix padding * chore: add redirect * merge * chore: content update * fix: typo * content * anna updates * chore: update text * Layout code (carbon-design-system#435) * test * layout code tab stuff * text updates * Apply suggestions from code review Co-Authored-By: Jan Child <44503588+janchild@users.noreply.github.com> * image updates * image updates * Update code.mdx * content and image updates * image update * img update * img update * text update * nav update * merge * content * anna updates * added a note about missing code snippet * fix: update class names
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 15, 2024
Restore ListBoxMenuIconTranslationKey type that was available in Carbon 10. Relatedly, fix ListBoxMenuIcon's translateWithId() signature so messageId is type ListBoxMenuIconTranslationKey, rather than just type string. Finally, do the identical fix to Dropdown's translateWithId() signature, and export a DropdownTranslationKey type. The translationIds objects from #435 (cc @joshblack) didn't seem to be helping, especially since they aren't exported from ListBox/index.ts. I removed ListBoxMenuIcon's translationIds object as part of adding this typing. Note that neither ListBoxMenuIconTranslationKey nor even ListBox itself is exported from @carbon/react. But Dropdown is. Co-authored-by: TJ Egan <tw15egan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #432