Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add accessibility guide with AVT1 block #3930

Merged
merged 3 commits into from
Sep 6, 2019
Merged

Conversation

joshblack
Copy link
Contributor

Somewhere down the line we lost the file added in: #1459 this PR looks to add it back in and re-structures it as a general purpose accessibility guide for development on the project.

Changelog

New

  • Add back in accessibility.md

Changed

Removed

@joshblack joshblack requested review from dakahn and a team September 6, 2019 16:51
@ghost ghost requested review from alisonjoseph and removed request for a team September 6, 2019 16:51
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this back in

@joshblack
Copy link
Contributor Author

Note to reviewers:

Going to re-structure the guide a bit so it has a structure we can add to (plus add doctoc) 👍

@netlify
Copy link

netlify bot commented Sep 6, 2019

Deploy preview for the-carbon-components ready!

Built with commit 90b566b

https://deploy-preview-3930--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Sep 6, 2019

Deploy preview for carbon-elements ready!

Built with commit 90b566b

https://deploy-preview-3930--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Sep 6, 2019

Deploy preview for carbon-components-react ready!

Built with commit 90b566b

https://deploy-preview-3930--carbon-components-react.netlify.com

Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joshblack joshblack merged commit 69f4839 into master Sep 6, 2019
@joshblack joshblack deleted the joshblack-patch-3 branch September 6, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants