Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(button): update iconDescription prop description #3924

Merged
merged 2 commits into from
Sep 6, 2019
Merged

docs(button): update iconDescription prop description #3924

merged 2 commits into from
Sep 6, 2019

Conversation

jendowns
Copy link
Contributor

@jendowns jendowns commented Sep 5, 2019

Changelog

New

  • update reference to old prop icon to new prop renderIcon

@netlify
Copy link

netlify bot commented Sep 5, 2019 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit e9d7fea

https://deploy-preview-3924--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Sep 5, 2019 •
edited
Loading

Deploy preview for carbon-elements failed.

Built with commit e9d7fea

https://app.netlify.com/sites/carbon-elements/deploys/5d71927778e26b0008e74d13

@netlify
Copy link

netlify bot commented Sep 5, 2019 •
edited
Loading

Deploy preview for carbon-components-react failed.

Built with commit e9d7fea

https://app.netlify.com/sites/carbon-components-react/deploys/5d7192763ffc860008a0a45f

@joshblack joshblack requested a review from a team September 5, 2019 22:43
@ghost ghost requested review from aledavila and dakahn and removed request for a team September 5, 2019 22:43
asudoh
asudoh approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - Thanks @jendowns!

@joshblack joshblack merged commit bbc27a4 into carbon-design-system:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@asudoh asudoh asudoh approved these changes

@aledavila aledavila Awaiting requested review from aledavila

@dakahn dakahn Awaiting requested review from dakahn

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jendowns @asudoh @joshblack