feat(TooltipIcon): port vanilla WCAG 2.1 fixes #3842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit f639fae https://deploy-preview-3842--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit f639fae https://deploy-preview-3842--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit f639fae |
joshblack
approved these changes
Aug 27, 2019
elizabethsjudd
approved these changes
Aug 27, 2019
laurenmrice
previously requested changes
Aug 28, 2019
ff643d4 to
b73b14f
Compare
|
looks like the top and bottom padding was 2px instead of 3px (carried over from the existing styles https://github.com/carbon-design-system/carbon/pull/2781/files#diff-93734be0784e9530b6d14a7b03b0d352L54), it should be fixed now |
69767de to
48cbecc
Compare
aagonzales
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3811
This PR ports the changes from #3115 to the React package
Testing / Reviewing
Ensure the icon tooltip appears and functions properly