-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button motion updates #370
Button motion updates #370
Conversation
👀 👍 ✅ |
👍 ✅ |
Hey @wonilsuh ! We're unfortunately going to close these PR's as they are a bit out of date right now, and we want to make sure we add Duo motion in when we're ready to add it to all of our components. Thank you for taking the time to explore motion with our components, and we look forward to continuing this work later this year! 🙂 |
carbon-design-system#370) * fixes carbon-design-system#363. added ability to provide a preselected option from the dropdown when selectedText is passed in from props * added selectedText conditional to value state * added constructor to dropdown component to check selectedText prop against children values. moved setting state logic inside constructor. added test case to cover passed in selectedText prop not matching any child value. * updated storybook. improved logic to check for preselected item.
* chore: add deploy stage to TravisCI config * chore: update to use latest yarn and run tests on one core * chore: revert changes to prod config
* chore: add script to scaffold metadata * chore(icons): add metadata.yml * chore(project): sync offline mirror
…n-system#370) * chore: remove vimeo stuff * refactor: remove vimeo, use native video element * use carbon icons instead of raw svg elements * fix: remove iframe and styles * fix: swap play/pause icon
Overview
Updates to the button motion with the System 360 Motion specs, which defines shorter duration and a set of new curves.
Added
A new
$bx-- ease-in-out
variable was added insrc/globals/scss/_vars.scss
@ibm/motion
was added as a dev dependency.proxies for the
@ibm/motion
methods were added:Changed
The following variables were updated:
Testing / Reviewing
Run
$ npm run test
and look under button unit test.Staging URL:
http://carbon-dev-environment-bracteate-akvavit.w3ibm.mybluemix.net/demo/primary-button