Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button motion updates #370

Closed
wants to merge 8 commits into from
Closed

Button motion updates #370

wants to merge 8 commits into from

Conversation

wonilsuh
Copy link

@wonilsuh wonilsuh commented Oct 17, 2017

Overview

Updates to the button motion with the System 360 Motion specs, which defines shorter duration and a set of new curves.

  • resubmitting after rebase fixes

Added

  • A new$bx-- ease-in-out variable was added in src/globals/scss/_vars.scss

  • @ibm/motion was added as a dev dependency.

  • proxies for the @ibm/motion methods were added:

src/globals/js/misc/motion-generator.js
src/globals/js/misc/motion-getDuration.js
src/globals/js/misc/motion-getCurve.js

Changed

The following variables were updated:

$bx--ease-in
$bx--ease-out
$bx--standard-easing
$transition--base
$transition-expansion

Testing / Reviewing

Run $ npm run test and look under button unit test.

Staging URL:

http://carbon-dev-environment-bracteate-akvavit.w3ibm.mybluemix.net/demo/primary-button

@aagonzales
Copy link
Member

aagonzales commented Nov 13, 2017

👀 👍 ✅
I don't know a whole lot about motion so I'll defer to Tayler's final say but I think this one feels pretty good and natural. It behaved as I would have expected to behave. I like the transition across the sets.

@tay-aitken
Copy link
Contributor

👍 ✅
This motion is snappy and at the appropriate speed for the component. A good improvement on the more delayed motion we had on the hover color change before. Good work on this one @wonilsuh!

@marijohannessen
Copy link
Contributor

Hey @wonilsuh ! We're unfortunately going to close these PR's as they are a bit out of date right now, and we want to make sure we add Duo motion in when we're ready to add it to all of our components. Thank you for taking the time to explore motion with our components, and we look forward to continuing this work later this year! 🙂

joshblack pushed a commit to joshblack/carbon that referenced this pull request May 2, 2019
carbon-design-system#370)

* fixes carbon-design-system#363. added ability to provide a preselected option from the dropdown when selectedText is passed in from props

* added selectedText conditional to value state

* added constructor to dropdown component to check selectedText prop against children values. moved setting state logic inside constructor. added test case to cover passed in  selectedText prop not matching any child value.

* updated storybook. improved logic to check for preselected item.
joshblack added a commit to joshblack/carbon that referenced this pull request May 2, 2019
* chore: add deploy stage to TravisCI config

* chore: update to use latest yarn and run tests on one core

* chore: revert changes to prod config
joshblack added a commit to joshblack/carbon that referenced this pull request May 8, 2019
* chore: add script to scaffold metadata

* chore(icons): add metadata.yml

* chore(project): sync offline mirror
designertyler pushed a commit to designertyler/carbon that referenced this pull request Oct 14, 2019
…n-system#370)

* chore: remove vimeo stuff

* refactor: remove vimeo, use native video element

* use carbon icons instead of raw svg elements

* fix: remove iframe and styles

* fix: swap play/pause icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants