Slider use number input #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realized the change to fix the old class name to |
|
@jamesvclements could you just make the selector |
|
Looks good to me, thanks for that! 👍 ✅ |
|
👍 ✅ |
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
* Fixes carbon-design-system#352. Added keyboard accessibility for navigating the Interior Left Nav. Move through the menu using `tab` and take action with either `enter` or the `spacebar`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Helps resolve #278 from the react repo.
Changes the input on the slider to be a number input, and selects it on focus. Added some webkit styles to remove the increment / decrement arrows.
Testing / Reviewing
Verified in Chrome, Firefox, Safari. Input type=number isn't supported in Edge