Toggle motion updates #365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asudoh
suggested changes
Oct 13, 2017
There was a problem hiding this comment.
@wonilsuh In addition to what I found in package.json, it appears that there are other places that your code is based on our older code. Please rectify so that the list of changes in this PR is kept with what you really want to change. Thanks!
package.json
Outdated
| @@ -78,13 +79,14 @@ | |||
| "gulp-util": "~3.0.7", | |||
| "husky": "^0.12.0", | |||
| "karma": "^1.0.0", | |||
| "karma-chrome-launcher": "^2.2.0", | |||
| "karma-chrome-launcher": "^2.0.0", | |||
There was a problem hiding this comment.
Seems that your code is based on our older code. This line should be kept ^2.2.0.
package.json
Outdated
| "karma-coverage": "^1.1.0", | ||
| "karma-firefox-launcher": "^1.0.0", | ||
| "karma-html2js-preprocessor": "^1.1.0", | ||
| "karma-ie-launcher": "^1.0.0", | ||
| "karma-mocha": "^1.3.0", | ||
| "karma-mocha-reporter": "~1.1.5", | ||
| "karma-phantomjs-launcher": "^1.0.0", |
There was a problem hiding this comment.
Seems that your code is based on our older code. This line should be removed.
package.json
Outdated
| @@ -97,6 +99,7 @@ | |||
| "mocha": "~2.4.4", | |||
| "mock-raf": "^1.0.0", | |||
| "nodemon": "1.9.1", | |||
| "phantomjs-prebuilt": "^2.1.3", | |||
There was a problem hiding this comment.
Seems that your code is based on our older code. This line should be removed.
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
designertyler
pushed a commit
to designertyler/carbon
that referenced
this pull request
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates to the toggle motion with the System 360 Motion specs, which defines shorter duration and a set of new curves.
Changed
Transition duration and curves updated.
Testing / Reviewing
Run
$ npm run test