-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Add loading spinner to button to convey action #3255
Conversation
Deploy preview for the-carbon-components ready! Built with commit ee1d6fa https://deploy-preview-3255--the-carbon-components.netlify.com |
Deploy preview for carbon-elements ready! Built with commit ee1d6fa |
Deploy preview for carbon-components-react ready! Built with commit ee1d6fa https://deploy-preview-3255--carbon-components-react.netlify.com |
Deploy preview for the-carbon-components ready! Built with commit 91cc7d1 https://deploy-preview-3255--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit 91cc7d1 https://deploy-preview-3255--carbon-components-react.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 91cc7d1 |
Deploy preview for the-carbon-components ready! Built with commit 5dbec21 https://deploy-preview-3255--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit 5dbec21 https://deploy-preview-3255--carbon-components-react.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 5dbec21 |
cc @carbon-design-system/design if you all have a chance to review this pattern 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aagonzales that is all this is adding. I will change the padding as suggested |
@aagonzales Any thoughts on how this effort relates to our inline loading component? Specificially, wanted to see if this variant should contain the completed state, or not. I'm guessing not, but just wanted to double-check. Thanks! |
@jeanservaas I have added a scenario to the original issue I had opened here. Please let me know if this is what you are looking for or if there is any other clarification I can provide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the dev side, it looks good to me. And based on the comments in the issue, it definitely seems like a use case we should support. Only thing that might change after design reviews is deciding if we'll stick with disabled colors for now or create new tokens for more of a "faded" primary button look. I'd prefer the latter, but I think it's up to design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd still like to see a version where the spinner code is not baked into <Button>
- Which means, story-only change.
|
@jeanservaas Thanks for the feedback. This PR was all pre our discussion that you reference above so I have no issue in using an enabled spinner. I am more than happy to make these changes but it seemed like @asudoh may be against this addition to the button. Either way, I am happy to update this PR however the Carbon team seems fit. I would love to have it baked in with the changes you mention here. Please advise. |
ah ok gotcha. Yeah, I would have to defer to @asudoh on the story only change. |
@davidicus Thank you for understanding - Let's go with story-only (and possibly with some style) changes for now. If we find the usage story (in consumer devs perspective) is very difficult we can re-consider. |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
not stale |
Hi @davidicus are you still working on this? |
@jnm2377 I will make a change to the storybook. Just had some other priorities. WIll update soon! |
Hi @davidicus thanks so much for taking the time to contribute this example. 🙏 It seems that this PR has been stale for a while. We'll be closing it in a week if it's not updated and merged by then. If you don't have the bandwidth to continue work for this in the next week, we'd be happy to have you open a PR again once you've had the chance to work on it. 💯 |
Closes #3254
Adds a spinner to the button component to indicate an action is being performed
Changelog
New
Changed
Testing / Reviewing
check the story. You should see a button with a spinner