fix(Modal): click-outside by mousedown #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit 6f5296b https://deploy-preview-3014--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 6f5296b |
|
Deploy preview for carbon-components-react ready! Built with commit 6f5296b https://deploy-preview-3014--carbon-components-react.netlify.com |
emyarod
approved these changes
Jun 11, 2019
aledavila
approved these changes
Jun 11, 2019
joshblack
approved these changes
Jun 11, 2019
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jun 12, 2019
emyarod
pushed a commit
to emyarod/carbon
that referenced
this pull request
Jun 18, 2019
2 tasks
kcprevatt
added a commit
to kcprevatt/carbon
that referenced
this pull request
Feb 13, 2023
kodiakhq bot
added a commit
that referenced
this pull request
Feb 16, 2023
* fix(ComposedModal): port mousedown changes from pr #3014 * chore(ContributorList): adding myself to contributor list * Revert "chore(ContributorList): adding myself to contributor list" This reverts commit 77a7c12. * chore(ContributorList): add myself to contributor list --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: TJ Egan <tw15egan@gmail.com>
remolueoend
pushed a commit
to remolueoend/carbon
that referenced
this pull request
Feb 17, 2023
…em#3014 (carbon-design-system#13140) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
remolueoend
pushed a commit
to remolueoend/carbon
that referenced
this pull request
Feb 17, 2023
…-system#13160) * fix(ComposedModal): port mousedown changes from pr carbon-design-system#3014 * chore(ContributorList): adding myself to contributor list * Revert "chore(ContributorList): adding myself to contributor list" This reverts commit 77a7c12. * chore(ContributorList): add myself to contributor list --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: TJ Egan <tw15egan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2968.
Changelog
Changed
mousedowninstead ofclickevent for "close-on-click-outside" behavior.Testing / Reviewing
Testing should make sure modal is not broken.