Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update peerDep ranges to react v19 #18458

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Jan 28, 2025

Closes #16620

Changelog

Changed

  • update allowed ranges to include v19
  • updates internal react deps to 18.3.1

Testing / Reviewing

  • Status checks should pass

Internal deps and the related type updates will land in #18207

@tay1orjones tay1orjones requested a review from a team as a code owner January 28, 2025 16:01
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 49955ef
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6798ff45f316f40008daecd5
😎 Deploy Preview https://deploy-preview-18458--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 49955ef
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6798ff4526736a00071701ac
😎 Deploy Preview https://deploy-preview-18458--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 49955ef
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6798ff45ebca4c000831f2bf
😎 Deploy Preview https://deploy-preview-18458--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (5a0348c) to head (49955ef).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18458   +/-   ##
=======================================
  Coverage   84.16%   84.16%           
=======================================
  Files         408      408           
  Lines       14449    14449           
  Branches     4696     4696           
=======================================
  Hits        12161    12161           
+ Misses       2124     2123    -1     
- Partials      164      165    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tay1orjones tay1orjones changed the title chore(deps): update ranges to react v19 chore(deps): update peerDep ranges to react v19 Jan 28, 2025
@annawen1 annawen1 added this pull request to the merge queue Jan 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 28, 2025
@riddhybansal riddhybansal added this pull request to the merge queue Jan 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 28, 2025
@2nikhiltom 2nikhiltom added this pull request to the merge queue Jan 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 29, 2025
@kennylam kennylam added this pull request to the merge queue Jan 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 29, 2025
@kennylam kennylam added this pull request to the merge queue Jan 29, 2025
@tay1orjones tay1orjones removed this pull request from the merge queue due to a manual request Jan 29, 2025
@tay1orjones tay1orjones merged commit ad0ba86 into carbon-design-system:main Jan 29, 2025
37 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.75.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Bug]: (Tabs) React 19 not rendering TabList items
3 participants