Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fluid-date-picker): decorator styles #18290

Conversation

ariellalgilmore
Copy link
Member

Closes #17995

looks like fluid-date-picker's decorator styles got accidentally missed when checking the form stories.

Changelog

Changed

  • added fluid-date-picker decorator styles
  • updated form stories

Testing / Reviewing

check form stories and make sure fluid-date-picker decorator is aligned correctly

@ariellalgilmore ariellalgilmore requested a review from a team as a code owner January 2, 2025 19:09
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit fdada15
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6776e9eb1fda16000849260a
😎 Deploy Preview https://deploy-preview-18290--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit fdada15
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6776e9eb720962000861299e
😎 Deploy Preview https://deploy-preview-18290--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit fdada15
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6776e9ebca061e0008df979f
😎 Deploy Preview https://deploy-preview-18290--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.15%. Comparing base (96b5a47) to head (fdada15).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18290   +/-   ##
=======================================
  Coverage   84.15%   84.15%           
=======================================
  Files         406      406           
  Lines       14407    14407           
  Branches     4686     4656   -30     
=======================================
  Hits        12124    12124           
+ Misses       2119     2118    -1     
- Partials      164      165    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for catching that

@annawen1 annawen1 enabled auto-merge January 2, 2025 20:25
@annawen1 annawen1 added this pull request to the merge queue Jan 2, 2025
Merged via the queue into carbon-design-system:main with commit 1abaf5a Jan 2, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decorator: Form
3 participants