test(FluidSearchSkeleton): add test file for component #17826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the DCO. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Mariat Sebastian <mariatsebastian189@gmail.com>
e8b0bb2 to
47760e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17826 +/- ##
==========================================
+ Coverage 80.14% 80.17% +0.02%
==========================================
Files 406 406
Lines 14030 14030
Branches 4391 4343 -48
==========================================
+ Hits 11245 11248 +3
+ Misses 2618 2616 -2
+ Partials 167 166 -1 ☔ View full report in Codecov by Sentry. |
kennylam
approved these changes
Oct 23, 2024
Merged
via the queue into
carbon-design-system:main
with commit Oct 23, 2024
b3e348b
26 of 27 checks passed
|
Hey there! v11.69.0 was just released that references this issue/PR. |
irfadkp
pushed a commit
to irfadkp/carbon
that referenced
this pull request
Oct 24, 2024
…-system#17826) * test(FluidSearchSkeleton): add test file for component * fix(FluidSearchSkeleton): corrected contributor file Signed-off-by: Mariat Sebastian <mariatsebastian189@gmail.com> --------- Signed-off-by: Mariat Sebastian <mariatsebastian189@gmail.com> Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17513
This PR adds unit tests for the FluidSearchSkeleton component to ensure its proper rendering and functionality. The tests verify that the skeleton displays with the correct classes, supports custom class names etc.
Changelog
Changed
Testing / Reviewing
Additional Notes
Please let me know if any further modifications are needed or if you have any questions regarding the changes.