Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utilities): add typescript declarations to dist #17797

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

janhassel
Copy link
Member

Adds typescript declarations to build output for @carbon/utilities and @carbon/utilities-react.

@janhassel janhassel requested a review from a team as a code owner October 18, 2024 14:06
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 5cfc743
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/671608e9dc4c84000800454d
😎 Deploy Preview https://deploy-preview-17797--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 5cfc743
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/671608e92366f40008a15e70
😎 Deploy Preview https://deploy-preview-17797--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5cfc743
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/671608e9cae7a40008e440a7
😎 Deploy Preview https://deploy-preview-17797--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (c1c8a8b) to head (5cfc743).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17797   +/-   ##
=======================================
  Coverage   79.86%   79.86%           
=======================================
  Files         406      406           
  Lines       14012    14012           
  Branches     4333     4353   +20     
=======================================
  Hits        11190    11190           
+ Misses       2657     2656    -1     
- Partials      165      166    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@alisonjoseph alisonjoseph added this pull request to the merge queue Oct 21, 2024
Merged via the queue into carbon-design-system:main with commit a8f6da7 Oct 21, 2024
39 of 40 checks passed
@janhassel janhassel deleted the utilities-ts branch October 22, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants