test(Dropdown): increase test coverage to 100% for Dropdown component #17785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17785 +/- ##
==========================================
+ Coverage 79.72% 80.08% +0.36%
==========================================
Files 406 406
Lines 14012 14011 -1
Branches 4333 4380 +47
==========================================
+ Hits 11171 11221 +50
+ Misses 2676 2624 -52
- Partials 165 166 +1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: andrew <emyarod@users.noreply.github.com>
alisonjoseph
approved these changes
Oct 21, 2024
Merged
via the queue into
carbon-design-system:main
with commit Oct 21, 2024
f2c4993
40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17477
test(Dropdown): increase test coverage to 100% for Dropdown component
Changelog
New
trueandfalsetrue|falseChanged
Removed
Testing / Reviewing
Test coverage has been increased to 100%, up from the previous 75%. I added mock tests for areas that were not covered in the earlier tests.
PASS packages/react/src/components/Dropdown/tests/Dropdown-test.js
Dropdown
✓ should initially render with the menu not open (19 ms)
✓ should let the user open the menu by clicking on the control (35 ms)
✓ should render with strings as items (16 ms)
✓ should render custom item components (14 ms)
✓ should render selectedItem as an element (3 ms)
✓ should render selectedItem as an element of type number (12 ms)
✓ should render when defaulItemtoString passed with null value (2 ms)
✓ should let the user select an option by clicking on the option node (43 ms)
✓ should respect readOnly prop (27 ms)
✓ should respect readOnly prop with false and respect call setTimeout function (15 ms)
✓ should respect readOnly prop with false argument and respect clear activated Timeout (9 ms)
✓ should initially render with the menu not open (1 ms)
title
✓ renders a title (2 ms)
✓ has the expected classes (2 ms)
helper
✓ renders a helper (2 ms)
✓ renders children as expected (6 ms)
should display initially selected item found in
initialSelectedItem✓ using an object type for the
initialSelectedItemprop (2 ms)✓ using a string type for the
initialSelectedItemprop (1 ms)Component API
✓ should accept a
reffor the underlying button element (1 ms)✓ should respect slug prop (3 ms)
DropdownSkeleton
Renders as expected
✓ Has the expected classes (1 ms)
Test useEffect
✓ for auto-align features (18 ms)
--------------|---------|----------|---------|---------|-------------------------------------------------------------------------