Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): add icon only 1px spacing #17671

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

alisonjoseph
Copy link
Member

Closes #17605

Changelog

  • add 1px space between icon only tabs

Testing / Reviewing

Check icon only tabs, should be 1px space between

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 2ffd466
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6705900548f7da0008bda45c
😎 Deploy Preview https://deploy-preview-17671--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 2ffd466
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/670590052060760007e71316
😎 Deploy Preview https://deploy-preview-17671--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisonjoseph alisonjoseph marked this pull request as ready for review October 7, 2024 18:18
@alisonjoseph alisonjoseph requested a review from a team as a code owner October 7, 2024 18:18
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.13%. Comparing base (21e4380) to head (2ffd466).
Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17671   +/-   ##
=======================================
  Coverage   77.13%   77.13%           
=======================================
  Files         409      409           
  Lines       14024    14024           
  Branches     4355     4327   -28     
=======================================
  Hits        10818    10818           
  Misses       3035     3035           
  Partials      171      171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@kennylam kennylam added this pull request to the merge queue Oct 10, 2024
Merged via the queue into carbon-design-system:main with commit f0cf217 Oct 10, 2024
35 of 36 checks passed
annawen1 pushed a commit to annawen1/carbon that referenced this pull request Oct 11, 2024
* fix(tabs): add icon only 1px spacing

* chore: cleanup story updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Line Tab Bug]: The 1px space between icon only line tabs is missing
5 participants