fix(icons): update square--solid svg #17560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
riddhybansal
approved these changes
Sep 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17560 +/- ##
=======================================
Coverage 77.03% 77.03%
=======================================
Files 408 408
Lines 13993 13993
Branches 4321 4301 -20
=======================================
Hits 10779 10779
- Misses 3041 3042 +1
+ Partials 173 172 -1 ☔ View full report in Codecov by Sentry. |
Merged
via the queue into
carbon-design-system:main
with commit Sep 30, 2024
759dfb3
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes carbon-design-system/carbon-website#4228
The Square--solid svg was rendering, however when it was converted to a React component the svg was rendering empty. This simplifies the svg code.
Changelog
Changed
Testing / Reviewing
you can build locally and check the SquareSolid component inside of icons-react before/after.