-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(definitiontooltip): increase test coverage to 100% #17434
test(definitiontooltip): increase test coverage to 100% #17434
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…finition-tooltip-test-coverage
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17434 +/- ##
==========================================
+ Coverage 77.08% 77.13% +0.05%
==========================================
Files 409 409
Lines 14024 14024
Branches 4327 4307 -20
==========================================
+ Hits 10810 10818 +8
+ Misses 3043 3036 -7
+ Partials 171 170 -1 ☔ View full report in Codecov by Sentry. |
How do we check the test coverage percentage locally ? |
packages/react/src/components/Tooltip/__tests__/DefinitionTooltip-test.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/Tooltip/__tests__/DefinitionTooltip-test.js
Outdated
Show resolved
Hide resolved
Hey @2nikhiltom We left this tips in the comment here |
@alisonjoseph Yeah that's is correct! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple tiny cleanup things but test coverage looks good 💯
packages/react/src/components/Tooltip/__tests__/DefinitionTooltip-test.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/Tooltip/__tests__/DefinitionTooltip-test.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/Tooltip/__tests__/DefinitionTooltip-test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after the clean up from Alison's comment
Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>
Updated, thanks everyone! |
21e4380
Hey there! v11.68.0 was just released that references this issue/PR. |
Closes #17415
Changelog
New
Testing / Reviewing