-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DataTable): Update DataTable to phase 2 spec #15662
feat(DataTable): Update DataTable to phase 2 spec #15662
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
@aagonzales just need a visual pass on this one, looks good to go on the dev side |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed it with TJ, looks good to go now! 🎉 ✅
927e5e4
to
d4d4d8b
Compare
421dbc4
Hey there! v11.50.0 was just released that references this issue/PR. |
Closes #15708
Updates the
DataTable
withSlug
to the new phase 2 styles. It also adds support for the full-column gradient.Changelog
New
$ai-aura-start-table
token, slightly more opaque than$ai-aura-start
getCellProps
prop getter added toTableCell
to check if a cell is in a column that has aSlug
in the headerai-table-gradient
mixin to specify theDataTable
specific gradientsChanged
TableCell
to a component, rather than usingwrapComponent
functionslug
can now be provided theDataTableHeader
, e.g. you would define your headers (with a slug) like so:Testing / Reviewing
Go to
Experiemental --> unstable__slug --> DataTable
and ensure all variants match the spec. Ensure there are no regressions to the mainDataTable