Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react-router using vite #15281

Conversation

andreancardona
Copy link
Contributor

Closes #15203

Changelog

New

  • working version of react-router using vite

Removed

  • removed old create react app example
  • removed unnecessary Tab Navigation example

Testing / Reviewing

cd packages/react/examples/react-router-vite and run yarn dev

@andreancardona andreancardona requested a review from a team as a code owner November 28, 2023 17:34
@andreancardona andreancardona changed the title 15203 cra migration react router feat: update react-router using vite Nov 28, 2023
Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 13e4186
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6566248fd3f80500089a6388
😎 Deploy Preview https://deploy-preview-15281--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 8d62a46
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/656767b4d331100008718205
😎 Deploy Preview https://deploy-preview-15281--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple tiny comments in the readme, but example LGTM!

packages/react/examples/react-router-vite/README.md Outdated Show resolved Hide resolved
packages/react/examples/react-router-vite/README.md Outdated Show resolved Hide resolved
andreancardona and others added 2 commits November 29, 2023 09:32
Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>
Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>
@andreancardona andreancardona added this pull request to the merge queue Nov 29, 2023
Merged via the queue into carbon-design-system:main with commit e8d477c Nov 29, 2023
19 checks passed
@andreancardona andreancardona deleted the 15203-cra-migration-react-router branch November 29, 2023 17:01
@carbon-automation
Copy link
Contributor

Hey there! v11.44.0 was just released that references this issue/PR.

danoro96 pushed a commit to danoro96/carbon that referenced this pull request Jan 18, 2024
* feat: update react-router with tabs

* feat: update react-router with tabs

* feat: cleaned up working example

* Update packages/react/examples/react-router-vite/README.md

Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>

* Update packages/react/examples/react-router-vite/README.md

Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>

---------

Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate off CRA: packages/react/examples/react-router
3 participants