-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update react-router using vite #15281
feat: update react-router using vite #15281
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple tiny comments in the readme, but example LGTM!
Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>
Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>
e8d477c
Hey there! v11.44.0 was just released that references this issue/PR. |
* feat: update react-router with tabs * feat: update react-router with tabs * feat: cleaned up working example * Update packages/react/examples/react-router-vite/README.md Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com> * Update packages/react/examples/react-router-vite/README.md Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com> --------- Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com>
Closes #15203
Changelog
New
Removed
Testing / Reviewing
cd
packages/react/examples/react-router-vite
and run yarn dev