Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added indicators to FileUploader #15274

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Nov 27, 2023

Closes #11196

Added a new aria attribute and changed html tags for FileUploader

Changelog

Changed

  • Added aria-describedby in the "Add File" button;
  • Changed p to h3 tag.

Testing / Reviewing

  • Check if the everything works as expected.
  • It shouldn't have any accessibility fails

@guidari guidari requested a review from a team as a code owner November 27, 2023 20:17
Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit efec5bb
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6564fba07752d7000824bee0
😎 Deploy Preview https://deploy-preview-15274--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added this pull request to the merge queue Nov 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 28, 2023
@guidari guidari added this pull request to the merge queue Nov 29, 2023
Merged via the queue into carbon-design-system:main with commit 856593f Nov 29, 2023
21 checks passed
@guidari guidari deleted the 11196-file-uploader branch November 29, 2023 13:17
@carbon-automation
Copy link
Contributor

Hey there! v11.44.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: Text preceding file uploader needs programmatic indicators
3 participants