refactor(NumberInput): remove pseudo elements and use box-shadow #15128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
andreancardona
approved these changes
Nov 8, 2023
tay1orjones
approved these changes
Nov 9, 2023
Merged
via the queue into
carbon-design-system:main
with commit Nov 9, 2023
b95c679
21 checks passed
danoro96
pushed a commit
to danoro96/carbon
that referenced
this pull request
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #15115
While working on adding the aura gradient to
NumberInput, I realized our use of::beforeand::afterelements were causing issues with the underlying backgrounds. This PR removes the usage of these pseudo-elements and instead sets dynamic insetbox-shadow's to style the stepper buttons when the input is focused, invalid, or the steppers are hovered while in these states. Also fixes some issues with the current implementation, seen below:Changelog
Changed
::beforeand::afterpseudo-element styles withbox-shadowon the stepper buttons.Removed
::beforeand::afterpseudo-elementslightspecific styles that are not doing anythingTesting / Reviewing
Go to
NumberInputandUnstable__NumberInputstories, and ensure the stepper styles are correct when the buttons are focused, hovered, hovered when input focused, focused when input invalid, and focused and hovered when input invalid.