Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(FluidMultiSelect): update propType definitions for FluidMultiSelect #15108

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Nov 6, 2023

Updates the FluidMultiSelect prop types to match what is used in Multiselect and FilterableMultiselect. Surfaced in slack

Changelog

Changed

  • Ported over props that are used in FluidMultiSelect from Multiselect

Testing / Reviewing

Ensure the prop types match Multiselect

Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit e832eca
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6549084dbbecde0008760ef6
😎 Deploy Preview https://deploy-preview-15108--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit e832eca
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6549084d108c440008a12a08
😎 Deploy Preview https://deploy-preview-15108--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tw15egan tw15egan requested a review from a team as a code owner November 6, 2023 15:37
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and looks good 🔥

@andreancardona andreancardona added this pull request to the merge queue Nov 6, 2023
Merged via the queue into carbon-design-system:main with commit d34d818 Nov 6, 2023
15 checks passed
danoro96 pushed a commit to danoro96/carbon that referenced this pull request Jan 18, 2024
…ect (carbon-design-system#15108)

* docs(FluidMultiSelect): update propType definitions for FluidMultiSelect

* test(snapshot): update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants