-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(FluidMultiSelect): update propType definitions for FluidMultiSelect #15108
Merged
andreancardona
merged 2 commits into
carbon-design-system:main
from
tw15egan:update-proptypes-fluidmultiselect
Nov 6, 2023
Merged
docs(FluidMultiSelect): update propType definitions for FluidMultiSelect #15108
andreancardona
merged 2 commits into
carbon-design-system:main
from
tw15egan:update-proptypes-fluidmultiselect
Nov 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Nov 6, 2023
tay1orjones
added
role: dev 🤖
component: multiselect
type: bug 🐛
severity: 2
https://ibm.biz/carbon-severity
labels
Nov 6, 2023
andreancardona
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and looks good 🔥
andreancardona
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
Nov 6, 2023
Merged
via the queue into
carbon-design-system:main
with commit Nov 6, 2023
d34d818
15 checks passed
danoro96
pushed a commit
to danoro96/carbon
that referenced
this pull request
Jan 18, 2024
…ect (carbon-design-system#15108) * docs(FluidMultiSelect): update propType definitions for FluidMultiSelect * test(snapshot): update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: multiselect
role: dev 🤖
severity: 2
https://ibm.biz/carbon-severity
status: ready for review 👀
status: ready to merge 🎉
type: bug 🐛
type: docs 📖
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
FluidMultiSelect
prop types to match what is used inMultiselect
andFilterableMultiselect
. Surfaced in slackChangelog
Changed
FluidMultiSelect
fromMultiselect
Testing / Reviewing
Ensure the prop types match
Multiselect