Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add types to TableBatchAction #15065

Merged
merged 2 commits into from
Oct 31, 2023
Merged

feat: add types to TableBatchAction #15065

merged 2 commits into from
Oct 31, 2023

Conversation

Tresau
Copy link
Contributor

@Tresau Tresau commented Oct 30, 2023

Closes #12519

Add Typescript typings to TableBatchAction

Changelog

New

  • Typescript typings for TableBatchAction

Changed

  • TableBatchAction.js-> TableBatchAction.tsx

Removed

  • n/a

Testing / Reviewing

Verify unit tests pass
Verify that storybook for DataTable-> BatchActions work as intended

@Tresau Tresau requested a review from a team as a code owner October 30, 2023 14:34
@netlify
Copy link

netlify bot commented Oct 30, 2023 •
edited
Loading

✅ Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 307d1a8
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/654167546f461d0008e2830b
😎 Deploy Preview https://deploy-preview-15065--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 30, 2023 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 307d1a8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/65416754e815950008a02bc3
😎 Deploy Preview https://deploy-preview-15065--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

andreancardona
andreancardona approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @Tresau-IBM !

@github-actions github-actions bot enabled auto-merge October 30, 2023 19:17
@github-actions github-actions bot added this pull request to the merge queue Oct 30, 2023
@tay1orjones tay1orjones removed this pull request from the merge queue due to the queue being cleared Oct 31, 2023
@tay1orjones tay1orjones enabled auto-merge October 31, 2023 20:46
@tay1orjones tay1orjones added this pull request to the merge queue Oct 31, 2023
Merged via the queue into carbon-design-system:main with commit 2c5f6ef Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreancardona andreancardona andreancardona approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

@tw15egan tw15egan Awaiting requested review from tw15egan tw15egan was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to TableBatchAction
3 participants
@Tresau @tay1orjones @andreancardona