-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): warnings from SideNav in console from inert prop #15047
fix(react): warnings from SideNav in console from inert prop #15047
Conversation
DCO Assistant Lite bot All contributors have signed the DCO. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I have read the DCO document and I hereby sign the DCO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once merge is resolved 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thank you for the contribution!
ffaf3e8
…design-system#14990) (carbon-design-system#15047) Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com> Co-authored-by: TJ Egan <tw15egan@gmail.com>
Closes #14990
Bug Description
In storybook, Rail type of SideNav will produce this console warning.
Changelog
Changed
inert
property fornav
HTML component. (line.242 in Sidebar.tsx)Testing / Reviewing
Checklist
(Cause)
The
inert
property throwing the error was passed boolean value.If a Sidebar component is Rail type, this condition returns
false
whichinert
property does not accept.It resulted as a console error, only for Rail type.
(Solution)
When
isRail
property gets passed to SideNav component, thatinert
property should beundefined
.Test
After opening up Rail type SideNav component in storybook, there is no this console warning anymore.