feat: Add Typescript typings to Breadcrumb, BreadcrumbItems, and BreadcrumbSkeleton #15033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO Assistant Lite bot All contributors have signed the DCO. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I have read the DCO document and I hereby sign the DCO. |
Tresau
commented
Oct 26, 2023
Comment on lines
+106
to
+107
| // @ts-expect-error - v12 TODO: BREAKING: This should match AriaAttributes['aria-current'] | ||
| 'aria-current': PropTypes.oneOfType([PropTypes.string, PropTypes.bool]), |
There was a problem hiding this comment.
I have created #15052 to address the Incorrect PropTypes to be accepted at a later time as it is a Breaking change.
alisonjoseph
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13546
Add typings to Breadcrumb, BreadcrumbItems, and BreadcrumbSkeleton. During work, discovered incorrect PropType in BreadcrumbItem for 'aria-current' and opened #15034 as a result.
Changelog
New
Changed
Removed
Testing / Reviewing
Verify that the storybooks run properly.
Run unit tests