Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): replaced SideNavMenuItem.js -> SideNavMenuItem.tsx component #14996

Merged
merged 10 commits into from
Oct 31, 2023

Conversation

Nirajsah
Copy link
Contributor

Closes #13607

To add a new file SideNavMenuItem.tsx with it's corresponding types.

Changelog

Changed

  • Updated TypeScript types for the SideNavMenuItem component to resolve type error.

Testing / Reviewing

To verify the changes:

  1. Ensure that the SideNavMenuItem component renders without any TypeScript errors.
  2. Test the component with different props and verify that it behaves as expected.
  3. Verify that the component works correctly in various usage scenarios, including cases with and without the isActive prop.
  4. Check if the component integrates seamlessly with the rest of the application's components and features.
  5. Run existing tests to ensure that the changes do not break any existing functionality.

@Nirajsah Nirajsah requested a review from a team as a code owner October 23, 2023 05:58
@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 5884aa9
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65415353b40a23000983277e
😎 Deploy Preview https://deploy-preview-14996--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 5884aa9
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/65415353a9e4570008cd6a73
😎 Deploy Preview https://deploy-preview-14996--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Nirajsah Nirajsah closed this Oct 28, 2023
@Nirajsah Nirajsah reopened this Oct 28, 2023
@Nirajsah
Copy link
Contributor Author

@alisonjoseph Thank you! 😇

@tw15egan tw15egan added this pull request to the merge queue Oct 30, 2023
@tay1orjones tay1orjones removed this pull request from the merge queue due to the queue being cleared Oct 31, 2023
@tay1orjones tay1orjones enabled auto-merge October 31, 2023 19:19
@tay1orjones tay1orjones added this pull request to the merge queue Oct 31, 2023
Merged via the queue into carbon-design-system:main with commit 57db818 Oct 31, 2023
14 checks passed
@Nirajsah Nirajsah deleted the SideNavMenuItem branch November 1, 2023 14:31
@kubijo
Copy link
Contributor

kubijo commented Nov 30, 2023

@tay1orjones, @alisonjoseph

This one no longer accepts props passable to the underlying Link component… namely to and as.
Was this change intentional?
The runtime code still uses Link and passes …rest props to it.

@tay1orjones
Copy link
Member

@kubijo No it wasn't intentional. What do you think is a reasonable course of action? Modify the extends to include Link, something like extends React.Component<LinkProps, {}>?

@kubijo
Copy link
Contributor

kubijo commented Nov 30, 2023

If the Link component already has types, I'd extend those or at least do Pick<LinkProps, …> for some reasonable subset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to SideNavMenuItem
6 participants