Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: added types to SideNavFooter #14863

Merged
merged 7 commits into from
Oct 31, 2023
Merged

refactor: added types to SideNavFooter #14863

merged 7 commits into from
Oct 31, 2023

Conversation

k-rajat19
Copy link
Contributor

Closes #13599

@k-rajat19 k-rajat19 requested a review from a team as a code owner October 11, 2023 09:56
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023 •
edited
Loading

DCO Assistant Lite bot All contributors have signed the DCO.

@netlify
Copy link

netlify bot commented Oct 11, 2023 •
edited
Loading

✅ Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 6649471
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6540fee0ff11ee0007d9b2b4
😎 Deploy Preview https://deploy-preview-14863--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 11, 2023 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6649471
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6540fee07dab770008cf77cc
😎 Deploy Preview https://deploy-preview-14863--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k-rajat19
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@k-rajat19
Copy link
Contributor Author

@tw15egan @tay1orjones I have fixed the conflicts, this is PR ready for review

tw15egan
tw15egan reviewed Oct 30, 2023
View reviewed changes
packages/react/src/components/UIShell/SideNavFooter.tsx
assistiveText: string;
className?: string;
expanded: boolean;
onToggle: (event: React.MouseEvent<HTMLButtonElement>) => void;
Copy link
Collaborator

@tw15egan tw15egan Oct 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add descriptions for each type? These can be copied from the PropType definitions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

andreancardona
andreancardona approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for contributing! 🎉

@andreancardona andreancardona added this pull request to the merge queue Oct 31, 2023
Merged via the queue into carbon-design-system:main with commit ca13646 Oct 31, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreancardona andreancardona andreancardona approved these changes

@tw15egan tw15egan tw15egan approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones tay1orjones was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to SideNavFooter
3 participants
@k-rajat19 @tw15egan @andreancardona