fix(date-picker): added heights to experimental and fixed arrow placement #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonjoseph
approved these changes
Nov 27, 2018
asudoh
approved these changes
Nov 28, 2018
|
🎉 This PR is included in version 9.56.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The experimental date-picker wasn't rendering correctly on the website (ref carbon-design-system/carbon-website#387). It was not showing the whole month. After some debugging, figured out that heights need to be specified for all the container - if not, the website will pull in the default
flatpickrstyles. I also fixed the placements of the arrows as they seemed off to me - but I can remove this if no one else experienced this issue.Arrows before:
Arrows after:
Changelog
Changed
_date-picker.scssTesting / Reviewing
Make sure date picker component isn't broken and that the arrows are aligned.