Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): ensure combobox has correct color when placed in modal #14489

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

tw15egan
Copy link
Collaborator

Closes #14486

Adjusts background color for ComboBox when placed inside a Modal

Changelog

Changed

  • Override for ComboBox styles in Modal

Testing / Reviewing

Place a ComboBox inside a Modal and ensure it has the correct background

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 57c6922
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64e4cb3c07a67b0008e61fc3
😎 Deploy Preview https://deploy-preview-14489--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 57c6922
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64e4cb3cd3f2a30008a98167
😎 Deploy Preview https://deploy-preview-14489--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones tay1orjones added this pull request to the merge queue Aug 24, 2023
Merged via the queue into carbon-design-system:main with commit d9a3ae9 Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: combobox layer is correct inside modals
3 participants